The lines that define fairways, greens, bunkers, water hazards, and tees should never intersect or partially overlap each other and we noticed that they are overlapping in one or more of the feature pairs in this changeset. If there is no obvious fringe around the green, the fairway should butt up against the green and every node between them should be *shared*. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). Please read the wiki for instructions and examples of how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks!

RE: way/1388235928

Please don't use the "lollipop" style of mapping golf course elements as you've done in the URL above. You need to create proper multipolygon relations in order to map features like roughs/bunkers that are within other features like fairways. Please see leisure=golf_course#Common_mapping_pitfalls and osm.wiki/Relation:multipolygon for help in understanding how to map this situation. If those aren't clear, please let me know and I'll help explain them further. Thanks.

RE: way/1388134712

Please don't use the "lollipop" style of mapping golf course elements as you've done in the URL above. You need to create proper multipolygon relations in order to map features like roughs/bunkers that are within other features like fairways. Please see leisure=golf_course#Common_mapping_pitfalls and osm.wiki/Relation:multipolygon for help in understanding how to map this situation. If those aren't clear, please let me know and I'll help explain them further. Thanks.

RE: way/1365420593

Hello Avprex,

As I mentioned in a previous comment on your changeset (changeset/163508500), fairways and greens shouldn't intersect/overlap like they do in the fairway mentioned above. Please refer to the wiki mentioned in those comments for how to map fairways and greens properly. Thanks.

Awesome. Glad to hear it. Thanks for getting back to me so quickly.

RE: way/1387572440

Hello Jim,

Please don't share the nodes of the green if you have the fairway surrounding the green. If you can't see any fringe around the green, you should make the fairway butt up to the green and share the nodes on the boundary *between* the green and fairway instead. Please read the wiki for visual examples and instructions on how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please let me know and I'll gladly help clarify things. Thanks!

Hello tizzzod,

Your fairway and green are overlapping in this changeset. They weren't before, but you made them overlap now. See the wiki for how to properly map fairways and greens. Either surround the green with a multipolygon around the fringe, or butt them up together. Here's the wiki: leisure=golf_course#Common_mapping_pitfalls

I'm not fan of temporary data, but I trust you more than other golf course mappers to do the right thing. Thanks. You're making some really nice looking courses I've noticed.

Go ahead and continue. The chances that our work would collide are 1 in 1,000 on any given night.

I work on courses across the country cleaning up mapping errors and looking for people making mistakes so I can correct their techniques (and prevent me from having to clean up future errors).

Yeah, I'm trying to clean up all of the bad examples of this style on the map so that new mappers don't get the idea that this is correct mapping. Check out the wiki and you'll see the right way to map around a fairway and green. Thanks!

Unfortunately there are a few bad tutorial videos out there and they refuse to update them with correct mapping techniques. So here we are scrambling to correct new mappers as soon as they show up on the scene.

Thanks for getting back to me. I'm happy to help correct bad habits. It will make my life easier in the future.

You are right that the previous way the fairway/green was mapped was also incorrect. At some point, I will work on correcting all existing ones like that (in the US). In the meantime, I'm pointing them out to new mappers.

You can absolutely go back and edit your fairway. Just pick two nodes on the fairway that are near the green. I think you have to shift-click to select two. Then you can right click and split the way into two ways and delete the one entering into the green. At that point, you should be able to continue drawing and snap to the boundary nodes. If that doesn't work, undo all the way and try deleting single fairway nodes that are inside the green and then just drag nodes until they snap to boundary nodes. (I really should make a video of how to do this. It would be easier to explain with video.)

third option: leave it as is and I'll get around to fixing it myself this year. I have 13,000 other fairways to fix and the goal is to finish them by the end of the year.

RE: way/1385667365

Hello Desync,

Please don't share the nodes of the green if you have the fairway surrounding the green. If you can't see any fringe around the green, you should make the fairway butt up to the green and share the nodes on the boundary *between* the green and fairway instead. Please read the wiki for visual examples and instructions on how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please let me know and I'll gladly help clarify things. Thanks!

RE: relation/19013022

Thanks for helping map golf courses. There are some problems with your edits however and your mapping process needs to be fixed going forward so you don't continue to step on the efforts of others. For starters, you should read the following wiki: osm.wiki/Keep_the_history on how important it is to *not* delete map elements when you should be modifying them instead. You break multipolygon relations when you delete something like a fairway that belongs to a relation only to redraw it and not properly add it back to the existing relation. You should also read the golf_course wiki (leisure=golf_course#Common_mapping_pitfalls) and the general wiki on how to properly work with multipolygons (osm.wiki/Relation:multipolygon#iD). Thanks.

RE: way/823646710

Hello Ad,

The lines that define fairways, greens, bunkers, water hazards, and tees should never intersect or partially overlap each other and we noticed that they are overlapping in one or more of the feature pairs in this changeset. If there is no obvious fringe around the green, the fairway should butt up against the green and every node between them should be *shared*. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). Please read the wiki for instructions and examples of how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things.

Thanks!

RE: way/1385495878

Hello Rick,
The lines that define fairways, greens, bunkers, water hazards, and tees should never intersect or partially overlap each other and we noticed that they are overlapping in one or more of the feature pairs in this changeset. If there is no obvious fringe around the green, the fairway should butt up against the green and every node between them should be *shared*. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). Please read the wiki for instructions and examples of how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks!

Ha! I also comment on my accidental oversized changesets to prevent people from yelling at me.
:)

Looks like you use that pattern already in other places, so maybe it just slipped your mind on this course. (See: way/1385463152)

Thanks for noticing this and fixing it (and correctly, to boot).

For the same reasons that fairways shouldn't intersect greens, roughs shouldn't intersect bunkers. Hopefully I can convince you that going around the outside of the bunker (with a gap), or around the inside (with or without a gap) is the right way to draw these going forward. Here is a before/after:

https://ibb.co/1FsxRxV vs. https://ibb.co/r2QHxcky

thanks.